ultanio/cobot
4
1
Fork 4
Code Issues 84 Pull requests 10 Projects Releases Packages Wiki Activity Actions

fix: correct run_loop_sync() to run_sync() in cli.py #98

Closed
doxios wants to merge 2 commits from fix/97-run-sync-typo into main
pull from: fix/97-run-sync-typo
merge into: ultanio:main
Conversation 0 Commits 2 Files changed 2 +46 -2
doxios commented 2026-02-26 12:29:26 +00:00
Collaborator
Copy link

run_loop_sync() does not exist on CobotAgent; the correct method is run_sync(). This typo caused cobot to crash on startup.

Fixes #97

`run_loop_sync()` does not exist on `CobotAgent`; the correct method is `run_sync()`. This typo caused cobot to crash on startup. Fixes #97
fix: correct run_loop_sync() to run_sync() in cli.py
All checks were successful
CI / lint (pull_request) Successful in 9s
Details
CI / test (3.11) (pull_request) Successful in 22s
Details
CI / test (3.12) (pull_request) Successful in 24s
Details
CI / test (3.13) (pull_request) Successful in 24s
Details
E2E Tests / e2e (pull_request) Successful in 15s
Details
CI / build (pull_request) Successful in 7s
Details
58638f26d5 
run_loop_sync() doesn't exist on CobotAgent; the correct method is
run_sync(). This typo caused cobot to crash on startup.

Fixes #97
test: add regression tests for cobot run startup paths (#97)
Some checks failed
CI / lint (pull_request) Successful in 9s
Details
CI / test (3.11) (pull_request) Failing after 17s
Details
CI / test (3.12) (pull_request) Failing after 18s
Details
CI / test (3.13) (pull_request) Failing after 18s
Details
CI / build (pull_request) Has been skipped
Details
E2E Tests / e2e (pull_request) Successful in 13s
Details
3b7c78054e 
Tests that 'cobot run' calls run_sync() (not run_loop_sync()) and
that 'cobot run --stdin' calls run_stdin_sync(). These would have
caught the #97 bug immediately.
doxios closed this pull request 2026-02-26 16:53:23 +00:00
Some checks failed
CI / lint (pull_request) Successful in 9s
Details
CI / test (3.11) (pull_request) Failing after 17s
Details
CI / test (3.12) (pull_request) Failing after 18s
Details
CI / test (3.13) (pull_request) Failing after 18s
Details
CI / build (pull_request) Has been skipped
Details
E2E Tests / e2e (pull_request) Successful in 13s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Competitor

Anything we found interesting at competitory

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Epic

Business requirement — groups related stories

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Story

Implementable unit with AC — results in a PR

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Scope/Core

Changes to core non-plugin code (CLI, config loading, etc.).

  
Scope/Cross-Plugin

Touches multiple existing plugins. Needs extra scrutiny, may require a PRD.

  
Scope/Plugin-System

Changes to plugin infrastructure (base.py, registry.py, interfaces.py, __init__.py, agent.py plugin dispatch). PRD required before merge.

  
Scope/Single-Plugin

Changes contained to one plugin (or adds one new plugin). Standard review.

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Competitor
Kind/Documentation
Kind/Enhancement
Kind/Epic
Kind/Feature
Kind/Security
Kind/Story
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Scope/Core
Scope/Cross-Plugin
Scope/Plugin-System
Scope/Single-Plugin
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ultanio/cobot!98
No description provided.