ultanio/cobot
4
1
Fork 4
Code Issues 84 Pull requests 10 Projects Releases Packages Wiki Activity Actions

fix: resolve plugin anti-pattern violations #79

Merged
k9ert merged 2 commits from fix/antipattern-cleanup into main 2026-02-22 13:16:46 +00:00
Conversation 0 Commits 2 Files changed 4 +12 -19
doxios commented 2026-02-22 13:10:48 +00:00
Collaborator
Copy link

Summary

Fixes easy anti-pattern violations identified in the plugin compliance audit.

Hidden Service Locator Fixes

Plugin Change
cron Add optional_dependencies for subagent, communication, filedrop
pairing Add optional_dependencies for communication

print() → log_*() Fixes

Plugin Change
loop Pass log_error callback to AggregatedToolProvider helper class
knowledge Replace print(..., file=sys.stderr) with self.log_info()

Remaining Violations

These are blocked on other work:

  • Environment Grab Bag (6 violations) — Needs #50 (secret management)
  • wallet, nostr, telegram, ppq, security, tools

Testing

  • All 345 tests pass
  • Lint passes
## Summary Fixes easy anti-pattern violations identified in the plugin compliance audit. ## Hidden Service Locator Fixes | Plugin | Change | |--------|--------| | cron | Add `optional_dependencies` for subagent, communication, filedrop | | pairing | Add `optional_dependencies` for communication | ## print() → log_*() Fixes | Plugin | Change | |--------|--------| | loop | Pass `log_error` callback to `AggregatedToolProvider` helper class | | knowledge | Replace `print(..., file=sys.stderr)` with `self.log_info()` | ## Remaining Violations These are blocked on other work: - **Environment Grab Bag (6 violations)** — Needs #50 (secret management) - wallet, nostr, telegram, ppq, security, tools ## Testing - All 345 tests pass - Lint passes
fix: resolve plugin anti-pattern violations
Some checks failed
CI / lint (pull_request) Failing after 9s
Details
CI / test (3.11) (pull_request) Successful in 21s
Details
CI / test (3.12) (pull_request) Successful in 24s
Details
E2E Tests / e2e (pull_request) Successful in 11s
Details
CI / test (3.13) (pull_request) Successful in 24s
Details
CI / build (pull_request) Has been skipped
Details
469a3a751b 
Hidden Service Locator fixes:
- cron: add optional_dependencies for subagent, communication, filedrop
- pairing: add optional_dependencies for communication

print() → log_*() fixes:
- loop: pass log_error callback to AggregatedToolProvider
- knowledge: replace print() with self.log_info()

All 345 tests pass.
style: fix line length in loop plugin
All checks were successful
CI / lint (pull_request) Successful in 9s
Details
CI / test (3.11) (pull_request) Successful in 21s
Details
E2E Tests / e2e (pull_request) Successful in 10s
Details
CI / test (3.12) (pull_request) Successful in 24s
Details
CI / test (3.13) (pull_request) Successful in 24s
Details
CI / build (pull_request) Successful in 7s
Details
4a7a55a5b2
k9ert merged commit 3b10112fd3 into main 2026-02-22 13:16:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Competitor

Anything we found interesting at competitory

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Epic

Business requirement — groups related stories

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Story

Implementable unit with AC — results in a PR

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Scope/Core

Changes to core non-plugin code (CLI, config loading, etc.).

  
Scope/Cross-Plugin

Touches multiple existing plugins. Needs extra scrutiny, may require a PRD.

  
Scope/Plugin-System

Changes to plugin infrastructure (base.py, registry.py, interfaces.py, __init__.py, agent.py plugin dispatch). PRD required before merge.

  
Scope/Single-Plugin

Changes contained to one plugin (or adds one new plugin). Standard review.

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Competitor
Kind/Documentation
Kind/Enhancement
Kind/Epic
Kind/Feature
Kind/Security
Kind/Story
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Scope/Core
Scope/Cross-Plugin
Scope/Plugin-System
Scope/Single-Plugin
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ultanio/cobot!79
No description provided.