ultanio/cobot
4
1
Fork 4
Code Issues 84 Pull requests 10 Projects Releases Packages Wiki Activity Actions

[#54] refactor: move plugin graph inspection into PluginRegistry #77

Closed
nazim wants to merge 1 commit from nazim/cobot:refactor/inspect-to-registry into main
pull from: nazim/cobot:refactor/inspect-to-registry
merge into: ultanio:main
Conversation 0 Commits 1 Files changed 3 +1027
nazim commented 2026-02-22 12:31:05 +00:00
Contributor
Copy link

Moves the graph-building logic into PluginRegistry.inspect() so the web plugin can use it at runtime with live data.

Changes

  • registry.py: Added inspect() method — builds graph from live registered plugins (no AST heuristics)
  • inspect.py: Added inspect_from_registry() wrapper, removed standalone serve_graph() server, kept all formatters + static scan_plugins() for CLI
  • test_inspect.py: 9 new tests for registry inspect, kept all existing tests

Why

The standalone --serve HTTP server was a prototype. The viz belongs in the web admin dashboard (#48), which has access to the live registry. PluginRegistry.inspect() gives it the graph data directly.

scan_plugins() stays for offline CLI use (cobot plugins inspect --format table).

44 tests passing.

Part of #54

Moves the graph-building logic into `PluginRegistry.inspect()` so the web plugin can use it at runtime with live data. ### Changes - **`registry.py`**: Added `inspect()` method — builds graph from live registered plugins (no AST heuristics) - **`inspect.py`**: Added `inspect_from_registry()` wrapper, removed standalone `serve_graph()` server, kept all formatters + static `scan_plugins()` for CLI - **`test_inspect.py`**: 9 new tests for registry inspect, kept all existing tests ### Why The standalone `--serve` HTTP server was a prototype. The viz belongs in the web admin dashboard (#48), which has access to the live registry. `PluginRegistry.inspect()` gives it the graph data directly. `scan_plugins()` stays for offline CLI use (`cobot plugins inspect --format table`). 44 tests passing. Part of #54
refactor: move plugin graph inspection into PluginRegistry
Some checks failed
CI / lint (pull_request) Failing after 9s
Details
CI / test (3.11) (pull_request) Successful in 22s
Details
CI / test (3.12) (pull_request) Successful in 23s
Details
E2E Tests / e2e (pull_request) Successful in 11s
Details
CI / test (3.13) (pull_request) Successful in 24s
Details
CI / build (pull_request) Has been skipped
Details
0f8a00615a 
- Add PluginRegistry.inspect() method for live graph building
- Keep scan_plugins() in inspect.py for offline CLI use
- Add inspect_from_registry() thin wrapper in inspect.py
- Remove standalone serve_graph() (web plugin will serve the viz)
- Add registry inspect tests
nazim force-pushed refactor/inspect-to-registry from 0f8a00615a
Some checks failed
CI / lint (pull_request) Failing after 9s
Details
CI / test (3.11) (pull_request) Successful in 22s
Details
CI / test (3.12) (pull_request) Successful in 23s
Details
E2E Tests / e2e (pull_request) Successful in 11s
Details
CI / test (3.13) (pull_request) Successful in 24s
Details
CI / build (pull_request) Has been skipped
Details
to 55fb566fec
Some checks failed
CI / lint (pull_request) Failing after 9s
Details
CI / test (3.11) (pull_request) Successful in 21s
Details
CI / test (3.12) (pull_request) Successful in 22s
Details
E2E Tests / e2e (pull_request) Successful in 11s
Details
CI / test (3.13) (pull_request) Successful in 23s
Details
CI / build (pull_request) Has been skipped
Details
2026-02-22 13:20:03 +00:00 Compare
nazim force-pushed refactor/inspect-to-registry from 55fb566fec
Some checks failed
CI / lint (pull_request) Failing after 9s
Details
CI / test (3.11) (pull_request) Successful in 21s
Details
CI / test (3.12) (pull_request) Successful in 22s
Details
E2E Tests / e2e (pull_request) Successful in 11s
Details
CI / test (3.13) (pull_request) Successful in 23s
Details
CI / build (pull_request) Has been skipped
Details
to e989c9b5d0
Some checks failed
CI / lint (pull_request) Failing after 9s
Details
CI / test (3.11) (pull_request) Successful in 22s
Details
CI / test (3.12) (pull_request) Successful in 23s
Details
E2E Tests / e2e (pull_request) Successful in 11s
Details
CI / test (3.13) (pull_request) Successful in 24s
Details
CI / build (pull_request) Has been skipped
Details
2026-02-22 13:21:18 +00:00 Compare
nazim force-pushed refactor/inspect-to-registry from e989c9b5d0
Some checks failed
CI / lint (pull_request) Failing after 9s
Details
CI / test (3.11) (pull_request) Successful in 22s
Details
CI / test (3.12) (pull_request) Successful in 23s
Details
E2E Tests / e2e (pull_request) Successful in 11s
Details
CI / test (3.13) (pull_request) Successful in 24s
Details
CI / build (pull_request) Has been skipped
Details
to fe6897fb9b
Some checks failed
CI / lint (pull_request) Failing after 9s
Details
CI / test (3.11) (pull_request) Successful in 21s
Details
CI / test (3.12) (pull_request) Successful in 24s
Details
E2E Tests / e2e (pull_request) Successful in 12s
Details
CI / test (3.13) (pull_request) Successful in 24s
Details
CI / build (pull_request) Has been skipped
Details
2026-02-22 13:23:22 +00:00 Compare
nazim force-pushed refactor/inspect-to-registry from fe6897fb9b
Some checks failed
CI / lint (pull_request) Failing after 9s
Details
CI / test (3.11) (pull_request) Successful in 21s
Details
CI / test (3.12) (pull_request) Successful in 24s
Details
E2E Tests / e2e (pull_request) Successful in 12s
Details
CI / test (3.13) (pull_request) Successful in 24s
Details
CI / build (pull_request) Has been skipped
Details
to d478157d78
Some checks failed
CI / lint (pull_request) Failing after 9s
Details
CI / test (3.11) (pull_request) Successful in 20s
Details
CI / test (3.12) (pull_request) Successful in 22s
Details
E2E Tests / e2e (pull_request) Successful in 10s
Details
CI / test (3.13) (pull_request) Successful in 24s
Details
CI / build (pull_request) Has been skipped
Details
2026-02-22 14:48:07 +00:00 Compare
doxios closed this pull request 2026-02-26 20:13:17 +00:00
Some checks failed
CI / lint (pull_request) Failing after 9s
Details
CI / test (3.11) (pull_request) Successful in 20s
Details
CI / test (3.12) (pull_request) Successful in 22s
Details
E2E Tests / e2e (pull_request) Successful in 10s
Details
CI / test (3.13) (pull_request) Successful in 24s
Details
CI / build (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Competitor

Anything we found interesting at competitory

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Epic

Business requirement — groups related stories

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Story

Implementable unit with AC — results in a PR

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Scope/Core

Changes to core non-plugin code (CLI, config loading, etc.).

  
Scope/Cross-Plugin

Touches multiple existing plugins. Needs extra scrutiny, may require a PRD.

  
Scope/Plugin-System

Changes to plugin infrastructure (base.py, registry.py, interfaces.py, __init__.py, agent.py plugin dispatch). PRD required before merge.

  
Scope/Single-Plugin

Changes contained to one plugin (or adds one new plugin). Standard review.

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Competitor
Kind/Documentation
Kind/Enhancement
Kind/Epic
Kind/Feature
Kind/Security
Kind/Story
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Scope/Core
Scope/Cross-Plugin
Scope/Plugin-System
Scope/Single-Plugin
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ultanio/cobot!77
No description provided.