fix: centralized logging and remaining scheduled execution fixes #64

Closed

doxios wants to merge 27 commits from feature/scheduled-execution into main

pull from: feature/scheduled-execution

merge into: ultanio:main

ultanio:main

ultanio:fix/filedrop-error-handling

ultanio:feat/communication-events

ultanio:kn/web-plugin-v2-product-brief

ultanio:feature/telegram-lurker

ultanio:docs/prd-plugin-dependency-tree

ultanio:feature/interaction-ledger-merged

ultanio:fix/headless-mode

ultanio:feature/dockerization

ultanio:fix/filedrop-malformed-json

ultanio:docs/product-brief

ultanio:docs/prd

ultanio:docs/bmad-brownfield-scan

ultanio:release/v0.2.0

ultanio:feat/176-workspace-location

ultanio:fix/174-exec-cwd

ultanio:fix/deploy-v2

ultanio:test/init-integration

ultanio:fix/deploy-command

ultanio:fix/graceful-plugin-discovery

ultanio:feat/trust-plugin

ultanio:fix/identity-and-wake

ultanio:fix/forgejo-ci-workflow

ultanio:fix/test-alpha-script

ultanio:fix/filedrop-reply-to-sender

ultanio:fix/filedrop-reply-logging

ultanio:feature/openai-compat

ultanio:fix/99-telegram-pairing-passthrough

ultanio:fix/deploy-chown

ultanio:chore/retrigger-deploy-2

ultanio:fix/retrigger-deploy

ultanio:feat/integration-tests

ultanio:feat/deploy-workspace-context

ultanio:fix/alpha-deploy-bugs

ultanio:fix/deploy-known-hosts

ultanio:fix/deploy-workflow-v2

ultanio:test/deploy-ci-verification

ultanio:fix/deploy-workflow-simplify

ultanio:fix/trigger-deploy-test

ultanio:fix/add-deploy-script

ultanio:fix/deploy-runner-label

ultanio:fix/deploy-debug

ultanio:fix/deploy-host-fingerprint

ultanio:feature/auto-deploy

ultanio:fix-97

ultanio:story-109

ultanio:fix/97-run-sync-typo

ultanio:story-108

ultanio:story-107

ultanio:story-106

ultanio:story-105

ultanio:story-103

ultanio:feat/colored-logs

ultanio:story-80

ultanio:fix/antipattern-cleanup

ultanio:story-75

ultanio:story-69

ultanio:story-70

ultanio:story-62

ultanio:story-61

ultanio:story-60

ultanio:feature/knowledge-plugin

ultanio:k9ert-patch-4

ultanio:k9ert-patch-3

ultanio:k9ert-patch-2

ultanio:k9ert-patch-1

Conversation 0 Commits 27 Files changed 42 +3113 -226

doxios commented 2026-02-22 11:17:10 +00:00

Collaborator

Copy link

Summary

This PR contains all the fixes made after PR #42 was merged:

Changes

• Centralized logging via Plugin base class
• All plugins migrated from print() to self.log_*()
• Config snake_case standardization
• Heartbeat config key fix
• Clean shutdown of cron poll_loop
• Development conventions documentation

Why

PR #42 was merged early, then we continued fixing issues. These fixes need to be in main before other PRs can work.

Tests

151 tests pass locally.

## Summary This PR contains all the fixes made after PR #42 was merged: ### Changes - Centralized logging via Plugin base class - All plugins migrated from print() to self.log_*() - Config snake_case standardization - Heartbeat config key fix - Clean shutdown of cron poll_loop - Development conventions documentation ### Why PR #42 was merged early, then we continued fixing issues. These fixes need to be in main before other PRs can work. ### Tests 151 tests pass locally.

doxios added 27 commits 2026-02-22 11:17:10 +00:00

feat: add scheduled execution plugins (subagent, cron, heartbeat) ... 3bcbb82ce1

Implements issue #35 - Scheduled Execution architecture.

## Plugins Added

### 1. Subagent Plugin (Phase 1)
- Spawn isolated sessions for delegated work
- Tool: spawn_subagent for agent use
- API: SubagentProvider.spawn() for plugin use
- Concurrency limiting, timeout support
- Extension points: before_spawn, after_spawn

### 2. Cron Plugin (Phase 2)
- Schedule jobs with cron expressions or intervals
- Two modes:
  - isolated: spawns subagent (no context)
  - main_session: injects into main session (full context)
- Output routing: log, file, telegram, filedrop
- Quiet hours support
- Dynamic job management via add_job/remove_job

### 3. Heartbeat Plugin (Phase 3)
- Convenience wrapper for periodic main session wake-up
- Simple config: enabled, interval_minutes, prompt_file
- Uses cron plugin internally
- Creates default HEARTBEAT.md if missing

## Architecture

- No changes to agent.py - everything via plugins
- Cron injects via session.poll_messages extension point
- Subagent uses existing LLM provider
- Heartbeat registers a cron job with mode: main_session

## Config Examples

```yaml
subagent:
  max_concurrent: 3
  default_timeout_seconds: 300

cron:
  jobs:
    - name: daily-report
      schedule: "0 9 * * *"
      mode: isolated
      prompt: "Generate daily summary"
    - name: custom-heartbeat
      schedule: "*/30 * * * *"
      mode: main_session
      prompt_file: custom.md

heartbeat:
  enabled: true
  interval_minutes: 15
  quiet_hours: "23:00-07:00"
```

Closes #35

docs: add scheduled execution to architecture and for-agents ... 55280c5c7d

- Add subagent, cron, heartbeat to directory structure
- Add scheduled execution section with mermaid diagram
- Update for-agents.md with:
  - Spawning subagents guide
  - Cron jobs configuration
  - Heartbeat setup
  - Updated extension points (loop.* instead of hooks)

refactor: move SubagentProvider interface to subagent plugin ... 7cb1ddfac2

- Remove SubagentResult and SubagentProvider from interfaces.py
- Define them in subagent/plugin.py instead
- Export from subagent/__init__.py
- Update test imports

Each plugin should define its own interface for better modularity.

feat(cron): add tools for agent job management ... 8ddb167a30

Add three tools for agents to manage cron jobs dynamically:
- cron_add_job: Create a new scheduled job
- cron_remove_job: Remove a job (system jobs protected)
- cron_list_jobs: List all configured jobs

This allows agents to schedule their own tasks without config changes.

test(e2e): add cron tools e2e tests ... 1b2e62e0f2

Test cron_add_job, cron_list_jobs, and cron_remove_job via stdin.
Requires PPQ_API_KEY like other LLM-dependent tests.

fix: wire session.poll_messages and fix async pattern ... 9afe45b066

- Loop plugin now calls session.poll_messages extension point
- Cron main_session jobs are merged into the poll results
- Fixed SubagentPlugin.execute() to use ThreadPoolExecutor
  (avoids RuntimeError when event loop already running)
- Added integration tests for cron/loop messaging
- Updated loop README with session.poll_messages docs

feat(cli): add cron and subagent CLI commands ... e0b76ff50a

Cron commands:
- cobot cron list: List all jobs with status
- cobot cron add <name> <schedule> <prompt>: Add a job
- cobot cron remove <name>: Remove a job
- cobot cron run <name>: Trigger job immediately
- cobot cron enable/disable <name>: Toggle job

Subagent commands:
- cobot subagent spawn <task>: Spawn isolated subagent
- cobot subagent status: Show concurrency status

fix: aggregate tools from all ToolProvider plugins ... 260b182830

The tools plugin now:
- Aggregates get_definitions() from all ToolProvider plugins
- Routes execute() calls to the appropriate plugin
- Checks restart_requested on all tool providers

This enables cron, subagent, knowledge, etc. tools to be
available to the agent without modifying the core tools plugin.

Added tests for tool aggregation and routing.

fix: tool aggregation and cron schedule parsing ... 168bb3640e

1. Loop plugin now uses AggregatedToolProvider to aggregate
   tools from ALL ToolProvider plugins (not just the first one)
   - Fixes issue where only cron tools were visible

2. Fixed cron schedule parsing for '* * * * *' (every minute)
   - Previously fell through to 15-minute default
   - Now correctly sets next_run to 60 seconds

Added tests for AggregatedToolProvider and cron schedules.

fix: cron jobs not firing in stdin mode ... 2f1fc0531f

Root cause: asyncio.run(init_plugins) creates event loop A where
cron scheduler task is started, then run_stdin_sync() creates a new
event loop B. The cron task in loop A is dead.

Fix:
1. Added registry.restart_all() to re-start plugins in new event loop
2. run_stdin() now:
   - Calls restart_all() to recreate background tasks
   - Runs a poll_loop() concurrently that polls session.poll_messages
   - Cron messages are processed and output is printed

Now main_session cron jobs fire correctly in stdin mode.

fix: enable persistence in stdin mode for conversation history ... ab670186bd

Stdin mode now enables persistence plugin automatically, which:
- Tracks conversation history per peer (keyed by 'stdin')
- Injects history via loop.transform_history extension
- Saves user/assistant messages via loop.on_message and loop.after_send

This fixes the context window issue where each message was treated
as a new conversation.

debug: add plugin startup logging ... 499506ddaf

Show which plugins are being started to debug persistence loading.

test: add persistence plugin tests ... 7b68acd535

Tests cover:
- Configuration (enabled/disabled)
- Message storage (user and assistant)
- History injection via transform_history
- Full conversation flow
- Separate conversations per peer
- File persistence (save/load)
- Stdin mode specific behavior

fix: stdin mode now calls extension points for persistence ... 576633c26b

stdin_loop now calls:
- loop.on_message before _respond (saves user message)
- loop.after_send after _respond (saves assistant message)

This enables the persistence plugin to track conversation
history in stdin mode, fixing the context window bug.

test: add 'remember numbers' scenario test ... fb1e467dc9

Tests the exact flow from stdin mode:
1. User says 'I'll tell you numbers, remember them'
2. User sends numbers one by one: 1, 2, 3, 7, 8, 9
3. User asks 'What are the numbers?'
4. Verify all numbers are in conversation history
5. Verify history injection includes all numbers

This validates the context window fix works correctly.

feat(config): log which config file is loaded ... 3c288cad46

Now shows:
[Config] Loaded from: /path/to/cobot.yml
[Config] Provider: ppq

Or if no config file found:
[Config] Using defaults (no config file found)

fix(config): show absolute path for config file db30f19cbf

chore: remove verbose registry logging ... 6944204bf0

Removed:
- [Registry] Started 'plugin'
- [Registry] Stopped 'plugin'
- [Registry] Starting N plugins: ...
- [Registry] Restarting N plugins...

Kept error logging for failures.

fix(tests): update mock_registry fixture for new extension methods ... 680ffa14bd

- Mock all_with_capability('tools') to return tools_plugin (for AggregatedToolProvider)
- Mock get_implementations() to return empty list (for call_extension)
- Apply ruff formatting to scheduled execution plugins

feat: centralized logging via base Plugin class ... 58e313aa49

- Add log/log_debug/log_info/log_warn/log_error methods to Plugin base class
- Add public log() method to LoggerPlugin
- Update heartbeat, cron, subagent plugins to use self.log_*()
- Fallback to stderr if logger plugin not available

fix(config): use centralized logging and show absolute config path 2ed03f9c2c

refactor: migrate all plugins to centralized logging ... a366b2aea7

- Remove duplicate config logging
- Migrate all plugins from print() to self.log_*()
- Timestamps now consistently handled by logger plugin

Updated plugins:
- base.py: call_extension error logging
- communication: all print statements
- compaction: startup and error logging
- context: all print statements
- filedrop: inbox and error logging
- loop: startup and error logging (helper class kept)
- memory: all print statements
- memory_files: startup logging
- nostr: all print statements
- ollama: startup and warning logging
- pairing: all print statements
- persistence: startup logging
- ppq: startup logging
- security: all print statements
- session: all print statements
- soul: startup logging
- telegram: all print statements
- wallet: startup logging
- workspace: startup logging

fix: heartbeat config keys and remaining logging issues ... 94422d16a6

- Accept both camelCase and snake_case config keys in heartbeat
- Migrate tools plugin to centralized logging
- Remove duplicate [Config] log from cli.py

docs: add development conventions, standardize on snake_case ... a48edb6268

- Remove camelCase config fallbacks from heartbeat
- Create docs/dev/conventions.md with coding standards
- Standardize all config keys to snake_case

fix: handle I/O errors during shutdown in logging ... 22f7d17370

- Wrap stderr writes in try/except for BlockingIOError, OSError, ValueError
- Prevents crash when logging during process shutdown

Revert "fix: handle I/O errors during shutdown in logging" ... 872d5e73c4

This reverts commit 22f7d17370.

fix(agent): clean shutdown of cron poll_loop in stdin mode ... b1027eca85

- Cancel poll_loop explicitly when stdin_loop finishes (Ctrl+D)
- Handle BlockingIOError/BrokenPipeError during shutdown
- Add cancellation check before expensive work in poll_loop
- Prevents crashes when cron outputs during shutdown

doxios closed this pull request 2026-02-22 11:21:00 +00:00

Some checks failed

Hide all checks

CI / lint (pull_request) Successful in 8s

Details

CI / test (3.11) (pull_request) Failing after 16s

Details

CI / test (3.12) (pull_request) Failing after 17s

Details

CI / test (3.13) (pull_request) Failing after 18s

Details

CI / build (pull_request) Has been skipped

Details

E2E Tests / e2e (pull_request) Successful in 8s

Details

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Competitor

Anything we found interesting at competitory

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Epic

Business requirement — groups related stories

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Story

Implementable unit with AC — results in a PR

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Scope/Core

Changes to core non-plugin code (CLI, config loading, etc.).

  

Scope/Cross-Plugin

Touches multiple existing plugins. Needs extra scrutiny, may require a PRD.

  

Scope/Plugin-System

Changes to plugin infrastructure (base.py, registry.py, interfaces.py, __init__.py, agent.py plugin dispatch). PRD required before merge.

  

Scope/Single-Plugin

Changes contained to one plugin (or adds one new plugin). Standard review.

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Compat/Breaking

Kind/Bug

Kind/Competitor

Kind/Documentation

Kind/Enhancement

Kind/Epic

Kind/Feature

Kind/Security

Kind/Story

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Scope/Core

Scope/Cross-Plugin

Scope/Plugin-System

Scope/Single-Plugin

Status

Abandoned

Status

Blocked

Status

Need More Info

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

ultanio/cobot!64

No description provided.