[#202] fix: quarantine malformed JSON in filedrop inbox #204

Merged

k9ert merged 1 commit from fix/filedrop-malformed-json into main

2026-03-05 19:49:25 +00:00

doxios commented

2026-03-05 16:38:21 +00:00

Collaborator

Closes #202

Problem

Malformed JSON in the filedrop inbox causes an infinite retry loop. The except block logs the error but leaves the file in the inbox, so the next poll cycle retries it forever.

Alpha was stuck in this loop for hours.

Fix

Added _quarantine_file() method that:

Adds file to _processed set (stops retrying)
Moves file to processed/ with _corrupted suffix
Logs a warning

Both poll_inbox() and the secondary poll method now catch json.JSONDecodeError separately and quarantine the file.

Tests

3 new tests:

Malformed JSON is quarantined (removed from inbox, _corrupted suffix in processed/)
Good messages still process after a bad one
Second poll after quarantine is clean (idempotent)

Closes #202 ## Problem Malformed JSON in the filedrop inbox causes an infinite retry loop. The except block logs the error but leaves the file in the inbox, so the next poll cycle retries it forever. Alpha was stuck in this loop for hours. ## Fix Added `_quarantine_file()` method that: 1. Adds file to `_processed` set (stops retrying) 2. Moves file to `processed/` with `_corrupted` suffix 3. Logs a warning Both `poll_inbox()` and the secondary poll method now catch `json.JSONDecodeError` separately and quarantine the file. ## Tests 3 new tests: - Malformed JSON is quarantined (removed from inbox, _corrupted suffix in processed/) - Good messages still process after a bad one - Second poll after quarantine is clean (idempotent)

doxios added 1 commit

2026-03-05 16:38:21 +00:00

[#202 ] fix: quarantine malformed JSON in filedrop inbox

CI / lint (pull_request) Successful in 9s

Details

CI / test (3.11) (pull_request) Successful in 20s

Details

CI / test (3.12) (pull_request) Successful in 22s

Details

CI / test (3.13) (pull_request) Successful in 22s

Details

E2E Tests / e2e (pull_request) Successful in 15s

Details

CI / build (pull_request) Successful in 7s

Details

b69c6f6917

Malformed JSON files in the inbox caused an infinite retry loop —
the except block logged the error but left the file in place, so
the next poll cycle retried it forever.

Now: JSONDecodeError and other exceptions move the file to
processed/ with a _corrupted suffix and skip it. Good messages
continue to process normally.

3 new tests covering quarantine, mixed good/bad files, and idempotency.

Closes #202