fix: tools plugin uses workspace path instead of cwd (#174) #175

Merged

k9ert merged 1 commit from fix/174-exec-cwd into main

2026-02-28 05:48:49 +00:00

doxios commented

2026-02-28 05:38:29 +00:00

Collaborator

Fixes #174

Problem

ToolsPlugin._base_dir defaulted to Path.cwd(), so the exec tool ran commands in whatever directory the process started in — not the agent's workspace.

Fix

configure() accepts _workspace_path from config (for testing)
start() resolves workspace path from registry via workspace.get_path() (same pattern as soul plugin)
_exec() passes cwd=self._base_dir to subprocess.run()

Tests

test_configure_workspace_path — verifies config sets base_dir
test_exec_runs_in_workspace_dir — verifies exec runs in workspace dir
All 25 tests pass, ruff check + format clean

Fixes #174 ## Problem `ToolsPlugin._base_dir` defaulted to `Path.cwd()`, so the exec tool ran commands in whatever directory the process started in — not the agent's workspace. ## Fix - `configure()` accepts `_workspace_path` from config (for testing) - `start()` resolves workspace path from registry via `workspace.get_path()` (same pattern as soul plugin) - `_exec()` passes `cwd=self._base_dir` to `subprocess.run()` ## Tests - `test_configure_workspace_path` — verifies config sets base_dir - `test_exec_runs_in_workspace_dir` — verifies exec runs in workspace dir - All 25 tests pass, ruff check + format clean

doxios added 1 commit

2026-02-28 05:38:29 +00:00

fix: tools plugin uses workspace path instead of cwd (#174 )

CI / lint (pull_request) Successful in 9s

Details

CI / test (3.11) (pull_request) Successful in 20s

Details

CI / test (3.12) (pull_request) Successful in 22s

Details

CI / test (3.13) (pull_request) Successful in 22s

Details

E2E Tests / e2e (pull_request) Successful in 14s

Details

CI / build (pull_request) Successful in 7s

Details

5f0f479f92

Zeus approved these changes

2026-02-28 05:47:07 +00:00

Zeus left a comment

Collaborator

LGTM. Clean fix — tools plugin gets workspace path from registry and passes it as cwd to subprocess. Tests cover both config injection and actual pwd verification.