[#97] Fix cli.py run_loop_sync() → run_sync() #117

Merged
k9ert merged 1 commit from fix-97 into main 2026-02-26 16:32:15 +00:00
Collaborator

Closes #97

Problem

cli.py:180 still called bot.run_loop_sync() which was renamed to bot.run_sync(). This broke non-stdin mode and kept Alpha down for a week (Feb 19–26).

This was supposed to land in PR #116 but #116 was merged before the fix commit was pushed.

Changes

  1. Fix: bot.run_loop_sync()bot.run_sync() in cli.py:180
  2. Test: test_cli_run_help — exercises cobot run --help via Click test runner
  3. Test: test_cli_run_invokes_run_sync — AST-parses cli.py and fails if any call to run_loop_sync exists

The AST test would have caught this bug immediately.

Closes #97 ## Problem `cli.py:180` still called `bot.run_loop_sync()` which was renamed to `bot.run_sync()`. This broke non-stdin mode and kept Alpha down for a week (Feb 19–26). This was supposed to land in PR #116 but #116 was merged before the fix commit was pushed. ## Changes 1. **Fix**: `bot.run_loop_sync()` → `bot.run_sync()` in `cli.py:180` 2. **Test**: `test_cli_run_help` — exercises `cobot run --help` via Click test runner 3. **Test**: `test_cli_run_invokes_run_sync` — AST-parses `cli.py` and fails if any call to `run_loop_sync` exists The AST test would have caught this bug immediately.
[#97] fix: cli.py run_loop_sync() → run_sync() + AST smoke test
All checks were successful
CI / lint (pull_request) Successful in 8s
CI / test (3.11) (pull_request) Successful in 23s
CI / test (3.12) (pull_request) Successful in 25s
CI / test (3.13) (pull_request) Successful in 24s
E2E Tests / e2e (pull_request) Successful in 16s
CI / build (pull_request) Successful in 7s
0578e95532
Fix the stale method call in cli.py:180 that broke non-stdin mode
since the run_loop_sync → run_sync rename.

Add two new smoke tests:
- test_cli_run_help: exercises 'cobot run --help' via Click test runner
- test_cli_run_invokes_run_sync: AST-parses cli.py to verify no stale
  method calls exist (would have caught #97 immediately)
k9ert approved these changes 2026-02-26 16:32:05 +00:00
k9ert merged commit 853c2a0876 into main 2026-02-26 16:32:15 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ultanio/cobot!117
No description provided.