[#97] Fix cli.py run_loop_sync() → run_sync() #117
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Competitor
Kind/Documentation
Kind/Enhancement
Kind/Epic
Kind/Feature
Kind/Security
Kind/Story
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Scope/Core
Scope/Cross-Plugin
Scope/Plugin-System
Scope/Single-Plugin
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
ultanio/cobot!117
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix-97"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #97
Problem
cli.py:180still calledbot.run_loop_sync()which was renamed tobot.run_sync(). This broke non-stdin mode and kept Alpha down for a week (Feb 19–26).This was supposed to land in PR #116 but #116 was merged before the fix commit was pushed.
Changes
bot.run_loop_sync()→bot.run_sync()incli.py:180test_cli_run_help— exercisescobot run --helpvia Click test runnertest_cli_run_invokes_run_sync— AST-parsescli.pyand fails if any call torun_loop_syncexistsThe AST test would have caught this bug immediately.