ultanio/cobot
4
1
Fork 4
Code Issues 84 Pull requests 10 Projects Releases Packages Wiki Activity Actions

[#103] Fix test collection errors (nostr, telegram optional imports) #110

Merged
k9ert merged 1 commit from story-103 into main 2026-02-26 15:45:38 +00:00
Conversation 1 Commits 1 Files changed 2 +17 -13
doxios commented 2026-02-26 14:56:47 +00:00
Collaborator
Copy link

Closes #103

Changes

Use pytest.importorskip() to gracefully skip tests when optional dependencies (pynostr, python-telegram-bot) are not installed, instead of crashing during test collection.

Also cleaned up unused imports (AsyncMock, CommunicationError) in telegram tests.

Acceptance Criteria

  • pytest --collect-only succeeds with no errors
  • Tests skipped gracefully when deps missing
  • Tests still run when deps ARE installed (nostr: 13 collected)
  • ruff check cobot/ passes

Results

  • 312 passed, 2 skipped, 0 errors
Closes #103 ## Changes Use `pytest.importorskip()` to gracefully skip tests when optional dependencies (`pynostr`, `python-telegram-bot`) are not installed, instead of crashing during test collection. Also cleaned up unused imports (`AsyncMock`, `CommunicationError`) in telegram tests. ## Acceptance Criteria - [x] `pytest --collect-only` succeeds with no errors - [x] Tests skipped gracefully when deps missing - [x] Tests still run when deps ARE installed (nostr: 13 collected) - [x] `ruff check cobot/` passes ## Results - 312 passed, 2 skipped, 0 errors
[#103] fix: guard optional imports in nostr and telegram tests
All checks were successful
CI / lint (pull_request) Successful in 9s
Details
CI / test (3.11) (pull_request) Successful in 22s
Details
CI / test (3.12) (pull_request) Successful in 24s
Details
CI / test (3.13) (pull_request) Successful in 25s
Details
E2E Tests / e2e (pull_request) Successful in 14s
Details
CI / build (pull_request) Successful in 7s
Details
fa5e5327d6 
Use pytest.importorskip() to gracefully skip tests when optional
dependencies (pynostr, python-telegram-bot) are not installed,
instead of crashing during test collection.

Also fix unused imports (AsyncMock, CommunicationError) in telegram tests.
k9ert approved these changes 2026-02-26 15:45:27 +00:00
k9ert merged commit 1596afb743 into main 2026-02-26 15:45:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
k9ert
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Competitor

Anything we found interesting at competitory

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Epic

Business requirement — groups related stories

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Story

Implementable unit with AC — results in a PR

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Scope/Core

Changes to core non-plugin code (CLI, config loading, etc.).

  
Scope/Cross-Plugin

Touches multiple existing plugins. Needs extra scrutiny, may require a PRD.

  
Scope/Plugin-System

Changes to plugin infrastructure (base.py, registry.py, interfaces.py, __init__.py, agent.py plugin dispatch). PRD required before merge.

  
Scope/Single-Plugin

Changes contained to one plugin (or adds one new plugin). Standard review.

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Competitor
Kind/Documentation
Kind/Enhancement
Kind/Epic
Kind/Feature
Kind/Security
Kind/Story
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Scope/Core
Scope/Cross-Plugin
Scope/Plugin-System
Scope/Single-Plugin
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ultanio/cobot!110
No description provided.