[#80] feat: web plugin with extension point architecture #81

Merged

k9ert merged 5 commits from story-80 into main 2026-02-22 14:46:15 +00:00

Conversation 2 Commits 5 Files changed 12 +1473 -1

doxios commented 2026-02-22 13:27:44 +00:00

Collaborator

Copy link

Closes #80

Changes

• Web plugin with extension_points: ["web.panels", "web.routes", "web.settings"]
• Built-in plugin graph panel contributed via implements: {"web.panels": "get_builtin_panels"}
• Uses registry.get_implementations() for extension point discovery
• Starlette server with graceful shutdown handling
• Localhost-only binding (127.0.0.1) by default
• No base class methods for web contribution — pure extension point pattern

Files Created

cobot/plugins/web/
├── __init__.py
├── plugin.py      # WebPlugin with extension points
├── server.py      # Starlette app with uvicorn
├── README.md      # Documentation
├── templates/
│   ├── base.html
│   ├── admin.html
│   └── plugins.html
├── static/
│   └── .gitkeep
└── tests/
    ├── __init__.py
    └── test_plugin.py  # 24 tests

Config Schema

web:
  enabled: true
  host: "127.0.0.1"
  port: 8080

Dependencies Added

New [project.optional-dependencies.web] in pyproject.toml:

• starlette>=0.35
• uvicorn>=0.25
• jinja2>=3.1

AC Checklist

• web plugin created with extension_points: ["web.panels", "web.routes", "web.settings"]
• No base class methods for web contribution
• At least one panel contributed via implements (plugin graph)
• registry.get_implementations() used for discovery
• Plugin graph visible as admin panel
• Starlette server starts on configured port
• Graceful shutdown handling
• Localhost-only binding by default

Test Results

24 passed in 0.03s

Closes #80 ## Changes - **Web plugin** with `extension_points: ["web.panels", "web.routes", "web.settings"]` - **Built-in plugin graph panel** contributed via `implements: {"web.panels": "get_builtin_panels"}` - Uses `registry.get_implementations()` for extension point discovery - **Starlette server** with graceful shutdown handling - **Localhost-only binding** (`127.0.0.1`) by default - No base class methods for web contribution — pure extension point pattern ## Files Created ``` cobot/plugins/web/ ├── __init__.py ├── plugin.py # WebPlugin with extension points ├── server.py # Starlette app with uvicorn ├── README.md # Documentation ├── templates/ │ ├── base.html │ ├── admin.html │ └── plugins.html ├── static/ │ └── .gitkeep └── tests/ ├── __init__.py └── test_plugin.py # 24 tests ``` ## Config Schema ```yaml web: enabled: true host: "127.0.0.1" port: 8080 ``` ## Dependencies Added New `[project.optional-dependencies.web]` in pyproject.toml: - starlette>=0.35 - uvicorn>=0.25 - jinja2>=3.1 ## AC Checklist - [x] `web` plugin created with `extension_points: ["web.panels", "web.routes", "web.settings"]` - [x] No base class methods for web contribution - [x] At least one panel contributed via `implements` (plugin graph) - [x] `registry.get_implementations()` used for discovery - [x] Plugin graph visible as admin panel - [x] Starlette server starts on configured port - [x] Graceful shutdown handling - [x] Localhost-only binding by default ## Test Results ``` 24 passed in 0.03s ```

doxios added 1 commit 2026-02-22 13:27:45 +00:00

[#80] feat: web plugin with extension point architecture ... a0c8bfb9ae

- Web plugin with extension_points: ['web.panels', 'web.routes', 'web.settings']
- Built-in plugin graph panel via implements: {'web.panels': 'get_builtin_panels'}
- Uses registry.get_implementations() for extension point discovery
- Starlette server with graceful shutdown
- Localhost-only binding (127.0.0.1) by default
- No base class methods for web contribution - pure extension point pattern
- 24 tests covering meta, config, panels, and lifecycle

doxios reviewed 2026-02-22 13:31:35 +00:00

doxios left a comment

Author

Collaborator

Copy link

PR Review: Web Plugin Extension Point Architecture

✅ Extension Point Architecture

Follows CLI pattern from #78 — Uses extension_points and implements in PluginMeta correctly.

• web.panels, web.routes, web.settings properly defined
• registry.get_implementations() used correctly in collect_panels() and collect_routes()
• Plugin implements its own extension point (dogfooding) with get_builtin_panels()

✅ Code Quality

plugin.py:

• Clean separation of concerns
• Factory function pattern ✅
• Proper lifecycle methods (configure, start, stop)
• Graceful task cancellation in stop()

server.py:

• Starlette best practices followed
• Conditional dependency import with HAS_DEPS guard
• autoescape=True in Jinja2 — XSS protection ✅
• Clean uvicorn integration

Templates:

• Modern CSS with variables
• Interactive SVG-based plugin graph (nice touch!)
• Responsive sidebar design

✅ Tests — 24/24 Passed

All tests pass with good coverage of:

• Meta validation
• Configuration (enabled, host, port)
• Panel collection and sorting
• Graph data generation
• Lifecycle methods

✅ Lint/Format

• ruff check → All checks passed!
• ruff format --check → All files formatted

✅ Security

• Default host: 127.0.0.1 (localhost-only) ✅
• Autoescape: Enabled in templates ✅
• No auth needed for localhost admin interface

📝 Suggestions (Non-blocking)

1. web.routes not wired up: collect_routes() is defined but never called in server.py. Routes from other plugins won't actually be mounted. Consider:

   • Adding dynamic route mounting in v1, or
   • Documenting it as "planned" like web.settings

2. Missing test for collect_routes(): Would be good to add coverage.

---

Verdict: APPROVE ✅

Solid implementation following established patterns. The extension point architecture is clean and matches the CLI plugin design from #78. Minor gaps in route mounting can be addressed in follow-up work.

Nice work on the plugin graph visualization! 🔌📊

## PR Review: Web Plugin Extension Point Architecture ### ✅ Extension Point Architecture **Follows CLI pattern from #78** — Uses `extension_points` and `implements` in PluginMeta correctly. - `web.panels`, `web.routes`, `web.settings` properly defined - `registry.get_implementations()` used correctly in `collect_panels()` and `collect_routes()` - Plugin implements its own extension point (dogfooding) with `get_builtin_panels()` ### ✅ Code Quality **plugin.py:** - Clean separation of concerns - Factory function pattern ✅ - Proper lifecycle methods (configure, start, stop) - Graceful task cancellation in `stop()` **server.py:** - Starlette best practices followed - Conditional dependency import with `HAS_DEPS` guard - `autoescape=True` in Jinja2 — XSS protection ✅ - Clean uvicorn integration **Templates:** - Modern CSS with variables - Interactive SVG-based plugin graph (nice touch!) - Responsive sidebar design ### ✅ Tests — 24/24 Passed All tests pass with good coverage of: - Meta validation - Configuration (enabled, host, port) - Panel collection and sorting - Graph data generation - Lifecycle methods ### ✅ Lint/Format - `ruff check` → All checks passed! - `ruff format --check` → All files formatted ### ✅ Security - **Default host:** `127.0.0.1` (localhost-only) ✅ - **Autoescape:** Enabled in templates ✅ - No auth needed for localhost admin interface ### 📝 Suggestions (Non-blocking) 1. **`web.routes` not wired up:** `collect_routes()` is defined but never called in `server.py`. Routes from other plugins won't actually be mounted. Consider: - Adding dynamic route mounting in v1, or - Documenting it as "planned" like `web.settings` 2. **Missing test for `collect_routes()`:** Would be good to add coverage. --- ### Verdict: **APPROVE** ✅ Solid implementation following established patterns. The extension point architecture is clean and matches the CLI plugin design from #78. Minor gaps in route mounting can be addressed in follow-up work. Nice work on the plugin graph visualization! 🔌📊

doxios reviewed 2026-02-22 13:32:26 +00:00

doxios left a comment

Author

Collaborator

Copy link

PR Review: Web Plugin Extension Point Architecture

✅ Extension Point Architecture

Follows CLI pattern from #78 — Uses extension_points and implements in PluginMeta correctly.

• web.panels, web.routes, web.settings properly defined
• registry.get_implementations() used correctly in collect_panels() and collect_routes()
• Plugin implements its own extension point (dogfooding) with get_builtin_panels()

✅ Code Quality

plugin.py:

• Clean separation of concerns
• Factory function pattern
• Proper lifecycle methods (configure, start, stop)
• Graceful task cancellation in stop()

server.py:

• Starlette best practices followed
• Conditional dependency import with HAS_DEPS guard
• autoescape=True in Jinja2 — XSS protection
• Clean uvicorn integration

Templates:

• Modern CSS with variables
• Interactive SVG-based plugin graph
• Responsive sidebar design

✅ Tests — 24/24 Passed

All tests pass with good coverage of meta validation, configuration, panel collection and sorting, graph data generation, and lifecycle methods.

✅ Lint/Format — All checks passed

✅ Security

• Default host: 127.0.0.1 (localhost-only)
• Autoescape enabled in templates

Suggestions (Non-blocking)

1. web.routes not wired up: collect_routes() is defined but never called in server.py. Consider adding dynamic route mounting or documenting it as planned.

2. Missing test for collect_routes(): Would be good to add coverage.

---

Verdict: APPROVE (self-review - awaiting external approval)

Solid implementation following established patterns. Minor gaps in route mounting can be addressed in follow-up work.

## PR Review: Web Plugin Extension Point Architecture ### ✅ Extension Point Architecture **Follows CLI pattern from #78** — Uses extension_points and implements in PluginMeta correctly. - web.panels, web.routes, web.settings properly defined - registry.get_implementations() used correctly in collect_panels() and collect_routes() - Plugin implements its own extension point (dogfooding) with get_builtin_panels() ### ✅ Code Quality **plugin.py:** - Clean separation of concerns - Factory function pattern - Proper lifecycle methods (configure, start, stop) - Graceful task cancellation in stop() **server.py:** - Starlette best practices followed - Conditional dependency import with HAS_DEPS guard - autoescape=True in Jinja2 — XSS protection - Clean uvicorn integration **Templates:** - Modern CSS with variables - Interactive SVG-based plugin graph - Responsive sidebar design ### ✅ Tests — 24/24 Passed All tests pass with good coverage of meta validation, configuration, panel collection and sorting, graph data generation, and lifecycle methods. ### ✅ Lint/Format — All checks passed ### ✅ Security - Default host: 127.0.0.1 (localhost-only) - Autoescape enabled in templates ### Suggestions (Non-blocking) 1. **web.routes not wired up:** collect_routes() is defined but never called in server.py. Consider adding dynamic route mounting or documenting it as planned. 2. **Missing test for collect_routes():** Would be good to add coverage. --- ### Verdict: APPROVE (self-review - awaiting external approval) Solid implementation following established patterns. Minor gaps in route mounting can be addressed in follow-up work.

doxios added 1 commit 2026-02-22 13:34:38 +00:00

fix: actually mount routes from web.routes extension point ... 590b6e20c4

- Call collect_routes() in server._create_app()
- Add contributed routes to Starlette app
- Add tests for collect_routes()

doxios added 1 commit 2026-02-22 14:03:24 +00:00

docs: comprehensive web plugin README with examples ... d82172f337

- Clarify that panels are nav entries, routes provide content
- Add complete example showing panel + route combo
- Add JSON API endpoint example (no panel)
- Add dynamic content example accessing other plugins
- Improve structure with tables and clear sections

doxios added 1 commit 2026-02-22 14:04:59 +00:00

refactor: extract CSS into separate files ... 140f0d6013

- Move core styles from base.html to static/css/main.css
- Move graph styles from plugins.html to static/css/graph.css
- Templates now link to external stylesheets
- Cleaner separation of concerns

doxios added 1 commit 2026-02-22 14:09:08 +00:00

feat: auto-prefix routes with plugin id ... f9a3661e4e

Routes are now auto-prefixed with the plugin id to avoid collisions:
- Relative paths (no leading /): 'balance' → '/<plugin_id>/balance'
- Absolute paths (leading /): '/health' → '/health' (no change)

Panel routes are also prefixed the same way for consistency.

Updated README with route prefixing documentation and examples.

k9ert merged commit 4efd0628df into main 2026-02-22 14:46:15 +00:00

k9ert referenced this pull request from a commit 2026-02-22 14:46:15 +00:00

[#80] feat: web plugin with extension point architecture (#81)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Competitor

Anything we found interesting at competitory

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Epic

Business requirement — groups related stories

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Story

Implementable unit with AC — results in a PR

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Scope/Core

Changes to core non-plugin code (CLI, config loading, etc.).

  

Scope/Cross-Plugin

Touches multiple existing plugins. Needs extra scrutiny, may require a PRD.

  

Scope/Plugin-System

Changes to plugin infrastructure (base.py, registry.py, interfaces.py, __init__.py, agent.py plugin dispatch). PRD required before merge.

  

Scope/Single-Plugin

Changes contained to one plugin (or adds one new plugin). Standard review.

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Compat/Breaking

Kind/Bug

Kind/Competitor

Kind/Documentation

Kind/Enhancement

Kind/Epic

Kind/Feature

Kind/Security

Kind/Story

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Scope/Core

Scope/Cross-Plugin

Scope/Plugin-System

Scope/Single-Plugin

Status

Abandoned

Status

Blocked

Status

Need More Info

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

ultanio/cobot!81

No description provided.