refactor: extract agent loop into plugin, unify hooks and extension points #34

Merged

k9ert merged 6 commits from nazim/cobot:refactor/loop-plugin-architecture into main 2026-02-20 17:00:18 +00:00

Conversation 1 Commits 6 Files changed 27 +1245 -724

nazim commented 2026-02-20 14:33:01 +00:00

Contributor

Copy link

Summary

Extracts the agent message loop from agent.py into a loop plugin, and replaces the 11 hardcoded hooks with extension points. One dispatch mechanism. Agent becomes a loop runner.

Closes #33

What changed

New: Loop plugin (cobot/plugins/loop/)

• Owns the poll → context → LLM → tools → send cycle
• Defines 11 extension points (loop.on_message, loop.before_llm, etc.)
• Other plugins participate via meta.implements declarations
• Multiple loop plugins can run concurrently (agent loop, heartbeat, DVM, cron)

Simplified: agent.py (394→80 lines)

class Cobot:
    async def run(self):
        loops = self.registry.all_with_capability("loop")
        await asyncio.gather(*[loop.run() for loop in loops])

New: call_extension() and call_extension_chain() on base Plugin

• call_extension(point) — collect results from all implementers
• call_extension_chain(point, ctx) — flow ctx through implementers (like old hooks)
• Replaces manual get_implementations() + iteration boilerplate

Auto-injected registry

• start_all() sets plugin._registry = self on every plugin
• Eliminates all set_registry() methods and get_registry() calls
• Every plugin can use self._registry and self.call_extension() immediately

Ported plugins

Plugin	Old (hook override)	New (implements)
logger	7 hook methods	implements: {"loop.on_message": "log_message_received", ...}
persistence	on_message_received, transform_history, on_after_send	Same methods via implements
compaction	transform_history	via implements
security	on_message_received	via implements
pairing	on_message_received	via implements
ppq	on_before_llm_call, on_after_llm_call	via implements
telegram	on_before_llm_call	via implements

Deprecated

• run_hook() in registry (stub, prints warning)
• HOOK_METHODS list (kept as reference, now lists extension point names)
• run() convenience function removed from __init__.py

Stats

• 17 files changed, 534 insertions, 572 deletions
• Net reduction: 38 lines (while adding a whole new plugin + two new base class methods)
• Zero new dependencies

## Summary Extracts the agent message loop from `agent.py` into a **loop plugin**, and replaces the 11 hardcoded hooks with **extension points**. One dispatch mechanism. Agent becomes a loop runner. Closes #33 ## What changed ### New: Loop plugin (`cobot/plugins/loop/`) - Owns the poll → context → LLM → tools → send cycle - Defines 11 extension points (`loop.on_message`, `loop.before_llm`, etc.) - Other plugins participate via `meta.implements` declarations - Multiple loop plugins can run concurrently (agent loop, heartbeat, DVM, cron) ### Simplified: `agent.py` (394→80 lines) ```python class Cobot: async def run(self): loops = self.registry.all_with_capability("loop") await asyncio.gather(*[loop.run() for loop in loops]) ``` ### New: `call_extension()` and `call_extension_chain()` on base Plugin - `call_extension(point)` — collect results from all implementers - `call_extension_chain(point, ctx)` — flow ctx through implementers (like old hooks) - Replaces manual `get_implementations()` + iteration boilerplate ### Auto-injected registry - `start_all()` sets `plugin._registry = self` on every plugin - Eliminates all `set_registry()` methods and `get_registry()` calls - Every plugin can use `self._registry` and `self.call_extension()` immediately ### Ported plugins | Plugin | Old (hook override) | New (implements) | |--------|-------------------|------------------| | logger | 7 hook methods | `implements: {"loop.on_message": "log_message_received", ...}` | | persistence | `on_message_received`, `transform_history`, `on_after_send` | Same methods via `implements` | | compaction | `transform_history` | via `implements` | | security | `on_message_received` | via `implements` | | pairing | `on_message_received` | via `implements` | | ppq | `on_before_llm_call`, `on_after_llm_call` | via `implements` | | telegram | `on_before_llm_call` | via `implements` | ### Deprecated - `run_hook()` in registry (stub, prints warning) - `HOOK_METHODS` list (kept as reference, now lists extension point names) - `run()` convenience function removed from `__init__.py` ## Stats - 17 files changed, 534 insertions, 572 deletions - Net reduction: **38 lines** (while adding a whole new plugin + two new base class methods) - Zero new dependencies

nazim added 1 commit 2026-02-20 14:33:01 +00:00

refactor: extract agent loop into plugin, unify hooks and extension points ... 9a51d1c42d

- New loop plugin (cobot/plugins/loop/) owns the message cycle
- agent.py reduced from 230+ lines to ~80 lines — just a loop runner
- All 11 hooks replaced by extension points on the loop plugin
- Plugins declare participation via meta.implements instead of method overrides
- Registry auto-injects _registry into all plugins (no more set_registry/get_registry)
- New call_extension() and call_extension_chain() on base Plugin class
- Multiple loop plugins run concurrently via asyncio.gather
- run_hook() deprecated (kept as stub for backwards compat)

Closes #33

k9ert force-pushed refactor/loop-plugin-architecture from 9a51d1c42d to b7c7346bab 2026-02-20 16:35:54 +00:00 Compare

nazim force-pushed refactor/loop-plugin-architecture from b7c7346bab to 0b4922abb5 2026-02-20 16:48:08 +00:00 Compare

nazim added 1 commit 2026-02-20 16:52:23 +00:00

fix: resolve ruff lint and format errors ... d35a21381d

- Remove unused import: time (loop/plugin.py)
- Remove unused import: HOOK_METHODS (registry.py)
- Fix F821: add TYPE_CHECKING import for PluginRegistry forward ref (base.py)
- Format: agent.py, loop/plugin.py (ruff format)

nazim force-pushed refactor/loop-plugin-architecture from d35a21381d to 19da7d83f9 2026-02-20 16:54:30 +00:00 Compare

k9ert added 1 commit 2026-02-20 16:58:02 +00:00

Merge branch 'main' into refactor/loop-plugin-architecture b091689854

k9ert approved these changes 2026-02-20 17:00:09 +00:00

k9ert left a comment

Owner

Copy link

LGTM

LGTM

k9ert merged commit 0619aecd64 into main 2026-02-20 17:00:18 +00:00

k9ert referenced this pull request from a commit 2026-02-20 17:00:19 +00:00

refactor: extract agent loop into plugin, unify hooks and extension points (#34)

Sign in to join this conversation.

Reviewers

No reviewers

k9ert

Labels

Clear labels   

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Competitor

Anything we found interesting at competitory

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Epic

Business requirement — groups related stories

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Story

Implementable unit with AC — results in a PR

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Scope/Core

Changes to core non-plugin code (CLI, config loading, etc.).

  

Scope/Cross-Plugin

Touches multiple existing plugins. Needs extra scrutiny, may require a PRD.

  

Scope/Plugin-System

Changes to plugin infrastructure (base.py, registry.py, interfaces.py, __init__.py, agent.py plugin dispatch). PRD required before merge.

  

Scope/Single-Plugin

Changes contained to one plugin (or adds one new plugin). Standard review.

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Compat/Breaking

Kind/Bug

Kind/Competitor

Kind/Documentation

Kind/Enhancement

Kind/Epic

Kind/Feature

Kind/Security

Kind/Story

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Scope/Core

Scope/Cross-Plugin

Scope/Plugin-System

Scope/Single-Plugin

Status

Abandoned

Status

Blocked

Status

Need More Info

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

ultanio/cobot!34

No description provided.