feat: improve dockerization #209

Merged

k9ert merged 12 commits from David/cobot:feature/dockerization into main 2026-03-08 10:40:55 +00:00

Conversation 2 Commits 12 Files changed 6 +81 -11

David commented 2026-03-06 11:19:17 +00:00

Contributor

Copy link

Adds Docker support for running Cobot in a container via docker-compose, including a Dockerfile fix for file ownership, a new docker-compose.yml, .env.example and quickstart documentation for the Docker workflow. Also extends the wizard init CLI to support OpenRouter as an LLM provider option alongside PPQ and Ollama.

Adds Docker support for running Cobot in a container via docker-compose, including a Dockerfile fix for file ownership, a new docker-compose.yml, .env.example and quickstart documentation for the Docker workflow. Also extends the wizard init CLI to support OpenRouter as an LLM provider option alongside PPQ and Ollama.

David added 10 commits 2026-03-06 11:19:17 +00:00

chore: add Docker support with docker-compose and update .gitignore ... 31a368f1ec

- Introduced a new docker-compose.yml file to define the cobot service with volume mappings for data and workspace.
- Updated .gitignore to include Docker-related directories: data/ and workspace/.

chore: update Dockerfile to set ownership of app directory ... 2e818ca59a

- Modified the Dockerfile to create a non-root user 'cobot' and assign ownership of the /app directory to this user, enhancing security and ensuring proper permissions.

docs: add .env.example and Docker setup instructions to quickstart guide ... 649bf2f16c

- Introduced a new .env.example file for environment variable configuration, including placeholders for API keys.
- Expanded the quickstart documentation to include steps for running Cobot in a Docker container, detailing environment setup and commands for interactive use.

feat: enhance LLM provider options in CLI ... d76c2357c0

- Updated the CLI to include "openrouter" as a new LLM provider alongside "ppq".
- Adjusted the configuration prompts to reflect the new provider options and their respective API settings.
- Improved default model and API base URL handling based on the selected provider.

Merge remote-tracking branch 'origin/main' into feature/dockerization 20ed5936a0

fix: trailing newline in .gitignore + docker health check ... 8e43a89c1d

- .gitignore: add missing trailing newline (POSIX compliance)
- docker-compose.yml: add simple health check (import cobot)

chore: update .gitignore to include BMad directories ... a2e194d1fe

- Added entries for BMad-related directories: _bmad/** and .claude/commands/**.
- Retained existing entries for Docker-related directories.

Merge remote-tracking branch 'refs/remotes/origin/feature/dockerization' into feature/dockerization d4182a97f4

chore: update .gitignore to include _bmad-output directory ... 37f381aef8

- Added entry for the _bmad-output directory to the .gitignore file.
- Retained existing entries for BMad and other relevant directories.

fix: handle PID 1 in Docker environment ... 86182a10b7

- Updated the read_pid function to unlink the PID file if the process is PID 1 in a Docker container, preventing false "already running" checks.
- This change ensures proper handling of the process lifecycle within Docker environments.

David referenced this pull request 2026-03-06 11:19:46 +00:00

feature/dockerization #201

David changed title from feature/dockerization to feat: improve dockerization 2026-03-06 11:25:27 +00:00

nazim commented 2026-03-06 15:53:21 +00:00

Contributor

Copy link

Review: Docker + OpenRouter wizard support

Clean PR — small, focused, and the quickstart docs are well-written. Some observations:

👍 What works well

• Dockerfile — slim base, non-root user, chown before USER cobot. Good practice.
• docker-compose.yml — simple, correct volume mounts. The healthcheck (import cobot) is a reasonable smoke test.
• Quickstart docs — the Docker section is clear and practical. docker compose run cobot wizard init --home for interactive setup inside the container is a nice UX.
• OpenRouter as wizard option — maps cleanly to the existing ppq provider config with just a different api_base. No new provider abstraction needed.

⚠️ Issues

1. .env.example names the key PPQ_API_KEY for OpenRouter

PPQ_API_KEY=sk-or-v1-your-openrouter-key-here

This is confusing — someone using OpenRouter has to set a variable called PPQ_API_KEY with an OpenRouter key. The wizard correctly distinguishes the two providers, but the env var naming leaks the abstraction. Consider either:

• Renaming to something generic like LLM_API_KEY, or
• Adding a comment: # Works for both PPQ and OpenRouter (same config path)

2. Wizard hardcodes anthropic/claude-sonnet-4 as OpenRouter default

default_model = "anthropic/claude-sonnet-4"

This is a specific (expensive) model. For a default in a setup wizard, something cheaper like anthropic/claude-3.5-haiku or openai/gpt-4o-mini would be more beginner-friendly. Users who want Sonnet will know to type it.

3. docker-compose.yml mounts ./workspace:/workspace but Dockerfile sets COBOT_WORKSPACE=/workspace
This works, but the workspace dir isn't created in the Dockerfile. If cobot run tries to write there before any volume is mounted (e.g., running without compose), it'll fail with a permission error since the non-root user can't create /workspace. Add RUN mkdir -p /workspace && chown cobot:cobot /workspace to the Dockerfile.

4. Healthcheck doesn't verify runtime
python -c "import cobot" only checks the package is installed, not that the agent is running. For a restart: unless-stopped service, a better healthcheck would be something like cobot status --json and checking the running field, or a simple PID file check.

5. .gitignore additions look like a full rewrite, not incremental
The diff shows +10 lines but the file content is a complete .gitignore (50+ lines). Was this file new or did it replace an existing one? If it replaced an existing one, make sure nothing important was dropped. If it's new — looks comprehensive and correct.

📝 Minor

• The wizard sets config["provider"] = "ppq" when provider == "openrouter" — this is the right internal mapping, but a comment explaining why would help future readers: # OpenRouter uses same config structure as PPQ (OpenAI-compatible API)
• The quickstart wizard example shows a Telegram user ID 769134210 — that's a real user ID (k9ert's). Consider using a clearly fake one like 123456789 to avoid confusion.

Verdict

Good incremental improvement. The Docker workflow is clean and the OpenRouter support slots in naturally. Fix the workspace directory permissions (#3) and consider the naming confusion (#1). The rest are polish items.

## Review: Docker + OpenRouter wizard support Clean PR — small, focused, and the quickstart docs are well-written. Some observations: ### 👍 What works well - **Dockerfile** — slim base, non-root user, `chown` before `USER cobot`. Good practice. - **docker-compose.yml** — simple, correct volume mounts. The healthcheck (`import cobot`) is a reasonable smoke test. - **Quickstart docs** — the Docker section is clear and practical. `docker compose run cobot wizard init --home` for interactive setup inside the container is a nice UX. - **OpenRouter as wizard option** — maps cleanly to the existing `ppq` provider config with just a different `api_base`. No new provider abstraction needed. ### ⚠️ Issues **1. `.env.example` names the key `PPQ_API_KEY` for OpenRouter** ``` PPQ_API_KEY=sk-or-v1-your-openrouter-key-here ``` This is confusing — someone using OpenRouter has to set a variable called `PPQ_API_KEY` with an OpenRouter key. The wizard correctly distinguishes the two providers, but the env var naming leaks the abstraction. Consider either: - Renaming to something generic like `LLM_API_KEY`, or - Adding a comment: `# Works for both PPQ and OpenRouter (same config path)` **2. Wizard hardcodes `anthropic/claude-sonnet-4` as OpenRouter default** ```python default_model = "anthropic/claude-sonnet-4" ``` This is a specific (expensive) model. For a default in a setup wizard, something cheaper like `anthropic/claude-3.5-haiku` or `openai/gpt-4o-mini` would be more beginner-friendly. Users who want Sonnet will know to type it. **3. `docker-compose.yml` mounts `./workspace:/workspace` but Dockerfile sets `COBOT_WORKSPACE=/workspace`** This works, but the workspace dir isn't created in the Dockerfile. If `cobot run` tries to write there before any volume is mounted (e.g., running without compose), it'll fail with a permission error since the non-root user can't create `/workspace`. Add `RUN mkdir -p /workspace && chown cobot:cobot /workspace` to the Dockerfile. **4. Healthcheck doesn't verify runtime** `python -c "import cobot"` only checks the package is installed, not that the agent is running. For a `restart: unless-stopped` service, a better healthcheck would be something like `cobot status --json` and checking the `running` field, or a simple PID file check. **5. `.gitignore` additions look like a full rewrite, not incremental** The diff shows +10 lines but the file content is a complete `.gitignore` (50+ lines). Was this file new or did it replace an existing one? If it replaced an existing one, make sure nothing important was dropped. If it's new — looks comprehensive and correct. ### 📝 Minor - The wizard sets `config["provider"] = "ppq"` when `provider == "openrouter"` — this is the right internal mapping, but a comment explaining why would help future readers: `# OpenRouter uses same config structure as PPQ (OpenAI-compatible API)` - The quickstart wizard example shows a Telegram user ID `769134210` — that's a real user ID (k9ert's). Consider using a clearly fake one like `123456789` to avoid confusion. ### Verdict Good incremental improvement. The Docker workflow is clean and the OpenRouter support slots in naturally. Fix the workspace directory permissions (#3) and consider the naming confusion (#1). The rest are polish items.

David added 1 commit 2026-03-07 02:57:30 +00:00

chore: remove bmad from gitignore 6b82d8814f

David added 1 commit 2026-03-07 03:06:35 +00:00

chore: update .env.example and Docker configuration ... a3f470e1d0

- Updated .env.example to clarify the usage of the LLM API key for both PPQ and OpenRouter.
- Modified docker-compose.yml health check command to use 'cobot status --json' for better status reporting.
- Enhanced Dockerfile to create a workspace directory and assign ownership to the non-root user.
- Added a comment in cli.py to indicate that OpenRouter shares the same configuration structure as PPQ.
- Updated quickstart.md with a placeholder for a sample Telegram user ID.

David commented 2026-03-08 03:52:24 +00:00

Author

Contributor

Copy link

@k9ert can we merge this?

@k9ert can we merge this?

doxios referenced this pull request 2026-03-08 07:06:34 +00:00

feat: add peer interaction ledger plugin #226

k9ert merged commit ae674f12ce into main 2026-03-08 10:40:55 +00:00

k9ert referenced this pull request from a commit 2026-03-08 10:40:57 +00:00

feat: improve dockerization (#209)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Competitor

Anything we found interesting at competitory

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Epic

Business requirement — groups related stories

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Story

Implementable unit with AC — results in a PR

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Scope/Core

Changes to core non-plugin code (CLI, config loading, etc.).

  

Scope/Cross-Plugin

Touches multiple existing plugins. Needs extra scrutiny, may require a PRD.

  

Scope/Plugin-System

Changes to plugin infrastructure (base.py, registry.py, interfaces.py, __init__.py, agent.py plugin dispatch). PRD required before merge.

  

Scope/Single-Plugin

Changes contained to one plugin (or adds one new plugin). Standard review.

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Compat/Breaking

Kind/Bug

Kind/Competitor

Kind/Documentation

Kind/Enhancement

Kind/Epic

Kind/Feature

Kind/Security

Kind/Story

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Scope/Core

Scope/Cross-Plugin

Scope/Plugin-System

Scope/Single-Plugin

Status

Abandoned

Status

Blocked

Status

Need More Info

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

ultanio/cobot!209

No description provided.