ultanio/cobot
4
1
Fork 4
Code Issues 84 Pull requests 10 Projects Releases Packages Wiki Activity Actions

fix: identity test + filedrop wake stdout leak (#160) #162

Merged
k9ert merged 2 commits from fix/identity-and-wake into main 2026-02-27 23:44:52 +00:00
Conversation 1 Commits 2 Files changed 3 +10 -2
doxios commented 2026-02-27 21:29:48 +00:00
Collaborator
Copy link

Two small fixes to get 7/7 integration tests passing:

  1. filedrop wake stdout leak — >/dev/null 2>&1 instead of just 2>/dev/null to suppress ANSI output that broke integer comparison in wait_for_response
  2. Identity test — Strengthened Alpha SOUL.md to emphasize name is "Alpha" so LLM responds correctly to identity questions

Closes #160

Two small fixes to get 7/7 integration tests passing: 1. **filedrop wake stdout leak** — `>/dev/null 2>&1` instead of just `2>/dev/null` to suppress ANSI output that broke integer comparison in `wait_for_response` 2. **Identity test** — Strengthened Alpha SOUL.md to emphasize name is "Alpha" so LLM responds correctly to identity questions Closes #160
- Fix filedrop wake stdout leak: redirect both stdout and stderr
- Strengthen Alpha SOUL.md to emphasize name is Alpha, not Cobot

Closes #160
Reinforces Alpha's identity so LLM consistently responds with
the correct name.

Closes #161
Zeus approved these changes 2026-02-27 21:30:21 +00:00
Zeus left a comment
Collaborator
Copy link

LGTM — clean fix. SOUL.md identity reinforcement works for now, we can add IDENTITY.md later if needed. ⚡

LGTM — clean fix. SOUL.md identity reinforcement works for now, we can add IDENTITY.md later if needed. ⚡
doxios force-pushed fix/identity-and-wake from dd8c2d4217 to 634809f724 2026-02-27 21:32:34 +00:00 Compare
k9ert force-pushed fix/identity-and-wake from 634809f724 to 5a860e998a
All checks were successful
CI / lint (pull_request) Successful in 8s
Details
CI / test (3.11) (pull_request) Successful in 17s
Details
CI / test (3.12) (pull_request) Successful in 19s
Details
CI / test (3.13) (pull_request) Successful in 19s
Details
E2E Tests / e2e (pull_request) Successful in 14s
Details
CI / build (pull_request) Successful in 7s
Details
2026-02-27 23:43:48 +00:00 Compare
k9ert merged commit 3156225228 into main 2026-02-27 23:44:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Zeus
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Competitor

Anything we found interesting at competitory

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Epic

Business requirement — groups related stories

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Story

Implementable unit with AC — results in a PR

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Scope/Core

Changes to core non-plugin code (CLI, config loading, etc.).

  
Scope/Cross-Plugin

Touches multiple existing plugins. Needs extra scrutiny, may require a PRD.

  
Scope/Plugin-System

Changes to plugin infrastructure (base.py, registry.py, interfaces.py, __init__.py, agent.py plugin dispatch). PRD required before merge.

  
Scope/Single-Plugin

Changes contained to one plugin (or adds one new plugin). Standard review.

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Competitor
Kind/Documentation
Kind/Enhancement
Kind/Epic
Kind/Feature
Kind/Security
Kind/Story
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Scope/Core
Scope/Cross-Plugin
Scope/Plugin-System
Scope/Single-Plugin
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ultanio/cobot!162
No description provided.