noopsec/architecture-template
1
0
Fork 0
Code Issues 3 Pull requests Projects Releases Packages Wiki Activity Actions

Python parser/validator is over-engineered for the use case #2

New issue
Open
opened 2026-03-01 10:43:35 +00:00 by Zeus · 0 comments
Zeus commented 2026-03-01 10:43:35 +00:00
Copy link

The bot/parser.py and bot/validator.py provide Python classes for template filling and validation. However:

  1. AI agents do not need Python imports to fill a markdown template — they just read the template and replace placeholders with real content
  2. The validator credential detection is too aggressive — flags any 40+ char alphanumeric string, which would match git commit hashes, API endpoint paths, and token references that are supposed to be in architecture docs
  3. The module is not actually installable — from architecture_template import ... will fail since there is no __init__.py or setup.py/pyproject.toml

Suggestion: Either:

  • (a) Remove Python tooling entirely and make this a pure template skill, or
  • (b) Package it properly with pyproject.toml and fix the overly aggressive patterns
The `bot/parser.py` and `bot/validator.py` provide Python classes for template filling and validation. However: 1. **AI agents do not need Python imports to fill a markdown template** — they just read the template and replace placeholders with real content 2. **The validator credential detection is too aggressive** — flags any 40+ char alphanumeric string, which would match git commit hashes, API endpoint paths, and token references that are *supposed* to be in architecture docs 3. **The module is not actually installable** — `from architecture_template import ...` will fail since there is no `__init__.py` or `setup.py`/`pyproject.toml` **Suggestion:** Either: - (a) Remove Python tooling entirely and make this a pure template skill, or - (b) Package it properly with pyproject.toml and fix the overly aggressive patterns
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
noopsec/architecture-template#2
No description provided.